Skip to content

WIP do not merge: Dump HTTP operations #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mtrmac wants to merge 1 commit into from
Closed

WIP do not merge: Dump HTTP operations #201

mtrmac wants to merge 1 commit into from

Conversation

@mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Jan 7, 2017 •
edited
Loading

Quite often it has been useful to dump the full HTTP request and response headers, and sometimes fuill bodies, for debugging; we probably should make that possible either automatically at the “debug” log level, or when the user sets an option.

This is by no means a workable implementation for that, but I’ve written exactly this hack two or three times now, so right now I am at least recording it for posterity, expecting that rebasing it will be easier than rewriting it.

A real implementation should, I guess, wrap a http.RoundTripper or perhaps http.Client (or just http.Client.Do?), or perhaps using net/http/httptrace somehow.

@runcom
Copy link
Member

runcom commented Jan 7, 2017

Isn't this adding overhead to the command? I'm fine with this, just want to make sure we don't wait that much dumping req/res.

@rhatdan
Copy link
Member

rhatdan commented Jan 9, 2017

Any way to pass down a debug flag? Or just rebuild with a DEBUG Tag?

@mtrmac
Copy link
Collaborator Author

mtrmac commented Jan 9, 2017

Isn't this adding overhead to the command?

Yes, and it completely clutters the debugging output. As I said

This is by no means a workable implementation

@mtrmac
Copy link
Collaborator Author

mtrmac commented Jan 9, 2017

Any way to pass down a debug flag? Or just rebuild with a DEBUG Tag?

We have a types.SystemContext which can be used to pass down such flags, yes.

@runcom runcom mentioned this pull request Jan 18, 2017
Merged
giuseppe pushed a commit to giuseppe/image that referenced this pull request Jan 24, 2017
@runcom
Merge pull request containers#201 from runcom/fix-198
d1d1d65 
vendor containers#84
@mtrmac mtrmac force-pushed the http-dump branch 4 times, most recently from 27bdf9e to eb7a685 Compare February 6, 2017 20:40
@mtrmac mtrmac force-pushed the http-dump branch 3 times, most recently from a49b9fb to a7f917d Compare March 2, 2017 20:15
@mtrmac mtrmac force-pushed the http-dump branch 2 times, most recently from 7db1b51 to 4a5b2b5 Compare March 4, 2017 04:40
@mtrmac mtrmac mentioned this pull request Mar 4, 2017
Closed
@mtrmac mtrmac force-pushed the http-dump branch 5 times, most recently from e7030b7 to b8d0cc5 Compare April 4, 2017 15:06
@mtrmac mtrmac force-pushed the http-dump branch 2 times, most recently from b727325 to ef4adfb Compare April 10, 2017 14:50
@mtrmac mtrmac force-pushed the http-dump branch 2 times, most recently from 2f2b680 to 974b583 Compare April 26, 2017 17:25
@mtrmac mtrmac added the kind/feature A request for, or a PR adding, new functionality label Dec 7, 2022
@mtrmac mtrmac force-pushed the http-dump branch 2 times, most recently from a47fd12 to 9daf744 Compare January 17, 2023 11:36
@mtrmac mtrmac force-pushed the http-dump branch 2 times, most recently from afb1bba to 8595d76 Compare February 8, 2023 20:02
@mtrmac mtrmac mentioned this pull request May 16, 2023
Closed
@mtrmac mtrmac mentioned this pull request Jul 26, 2023
Closed
@mtrmac mtrmac mentioned this pull request Aug 17, 2023
Open
@mtrmac mtrmac force-pushed the http-dump branch 2 times, most recently from 4f07126 to 92b4a86 Compare September 5, 2023 20:12
@mtrmac
Copy link
Collaborator Author

mtrmac commented Jun 27, 2024

In addition to the previously-noted concerns about opt-in, this should almost certainly be reworked to become a http.RoundTripper, wrapper, so that all redirects are logged.

@mtrmac mtrmac marked this pull request as draft June 27, 2024 20:31
@kwilczynski
Copy link
Member

kwilczynski commented Jul 9, 2024

This would be very useful for troubleshooting issues with access to remote registries. At the moment, I tend to opt for a set up with a transparent TLS proxy to snoop on this type of traffic, but having a log that exposes this type of data that can be easily enabled would be ideal.

@kwilczynski kwilczynski mentioned this pull request Jul 9, 2024
Merged
@mtrmac
Copy link
Collaborator Author

mtrmac commented Jul 9, 2024

For the record, Red Hat internal tracking: https://issues.redhat.com/browse/RHEL-36783

@mtrmac
WARNING: Dump HTTP requests/responses at logrus Trace level
5dcea2c 
WARNING: This includes credentials, if any.

Signed-off-by: Miloslav Trmač <[email protected]>
@mtrmac mtrmac mentioned this pull request Feb 12, 2025
Closed
@mtrmac mtrmac mentioned this pull request Jun 20, 2025
Closed
@jankaluza
Copy link
Member

jankaluza commented Aug 26, 2025

Hi, and thank you for your contribution!

We’ve recently migrated this repository into a new monorepo: containers/container-libs along with other repositories

As part of this migration, this repository is no longer accepting new Pull-Requests and therefore this Pull-Request is being closed.

Thank you very much for your contribution. We would appreciate your continued help in migrating this PR to the new container-libs repository. Please let us know if you are facing any issues.

You can read more about the migration and the reasoning behind it in our blog post: Upcoming migration of three containers repositories to monorepo.

Thanks again for your work and for supporting the containers ecosystem!

@jankaluza jankaluza closed this Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vrothberg vrothberg vrothberg left review comments

Assignees

No one assigned

Labels

kind/feature A request for, or a PR adding, new functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mtrmac @runcom @rhatdan @vrothberg @kwilczynski @jankaluza